refactor: replace types/eslint-scope.d.ts with @types/eslint-scope#595
Merged
MichaelDeBoey merged 1 commit intoJan 20, 2026
Merged
Conversation
This change re-adds `@types/eslint-scope` and replaces the custom types added while fixing the repo's build errors, following the fix from DefinitelyTyped/DefinitelyTyped#74308 being merged.
types/eslint-scope.d.ts with @types/eslint-scope
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the custom types/eslint-scope.d.ts type definitions with the official @types/eslint-scope package, following a fix in DefinitelyTyped that resolved type incompatibilities between eslint-scope and ESLint's built-in types.
Changes:
- Removes custom type definitions file that was created as a temporary workaround
- Adds @types/eslint-scope v8.4.0 and downgrades eslint-scope from v9.1.0 to v8.4.0 to align with ESLint v9
- Removes no-longer-needed dependencies (@types/esrecurse and eslint-visitor-keys)
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| types/eslint-scope.d.ts | Removes entire custom type definitions file (544 lines) that was a temporary workaround |
| tsconfig.json | Removes path mapping for eslint-scope that pointed to the custom types file |
| package.json | Adds @types/eslint-scope, adjusts eslint-scope version to 8.4.0, removes @types/esrecurse and eslint-visitor-keys |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MichaelDeBoey
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change re-adds
@types/eslint-scopeand replaces the custom types added while fixing the repo's build errors, following the fix from DefinitelyTyped/DefinitelyTyped#74308 being merged.Fixes #582