Skip to content

refactor: replace types/eslint-scope.d.ts with @types/eslint-scope#595

Merged
MichaelDeBoey merged 1 commit into
eslint-community:mainfrom
michaelfaith:refactor/eslint-scope-types
Jan 20, 2026
Merged

refactor: replace types/eslint-scope.d.ts with @types/eslint-scope#595
MichaelDeBoey merged 1 commit into
eslint-community:mainfrom
michaelfaith:refactor/eslint-scope-types

Conversation

@michaelfaith
Copy link
Copy Markdown
Contributor

This change re-adds @types/eslint-scope and replaces the custom types added while fixing the repo's build errors, following the fix from DefinitelyTyped/DefinitelyTyped#74308 being merged.

Fixes #582

This change re-adds `@types/eslint-scope` and replaces the
custom types added while fixing the repo's build errors,
following the fix from DefinitelyTyped/DefinitelyTyped#74308 being merged.
@MichaelDeBoey MichaelDeBoey changed the title refactor: replace custom eslint-scope types with updated version refactor: replace types/eslint-scope.d.ts with @types/eslint-scope Jan 20, 2026
@MichaelDeBoey MichaelDeBoey requested a review from Copilot January 20, 2026 11:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces the custom types/eslint-scope.d.ts type definitions with the official @types/eslint-scope package, following a fix in DefinitelyTyped that resolved type incompatibilities between eslint-scope and ESLint's built-in types.

Changes:

  • Removes custom type definitions file that was created as a temporary workaround
  • Adds @types/eslint-scope v8.4.0 and downgrades eslint-scope from v9.1.0 to v8.4.0 to align with ESLint v9
  • Removes no-longer-needed dependencies (@types/esrecurse and eslint-visitor-keys)

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

File Description
types/eslint-scope.d.ts Removes entire custom type definitions file (544 lines) that was a temporary workaround
tsconfig.json Removes path mapping for eslint-scope that pointed to the custom types file
package.json Adds @types/eslint-scope, adjusts eslint-scope version to 8.4.0, removes @types/esrecurse and eslint-visitor-keys

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@michaelfaith michaelfaith marked this pull request as ready for review January 20, 2026 11:47
@MichaelDeBoey MichaelDeBoey merged commit cb532f3 into eslint-community:main Jan 20, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace types/eslint-scope.d.ts with updated @types/eslint-scope

3 participants