Convert to ES6 that is supported on Node 4, commonjs modules and remove Babel#11
Convert to ES6 that is supported on Node 4, commonjs modules and remove Babel#11corbinu wants to merge 10 commits into
Conversation
not-an-aardvark
left a comment
not-an-aardvark
left a comment
There was a problem hiding this comment.
LGTM, just waiting for someone else to review.
| this.visitChildren(node.body); | ||
| } else { | ||
| this.visit(node.body); | ||
| if (node.body) { |
There was a problem hiding this comment.
This code change should not be in this PR, it is being applied via #2
There was a problem hiding this comment.
Sorry thought I had gotten that out with all my reattempts one sec
# Conflicts: # gulpfile.js # package.json
|
Please can you rebase this (and all your other PRs)? Merging in master is less safe than rebasing, and maintaining a messy commit history does not really make sense on small-scale PRs. We are currently not enforcing it, but commits should be following our contributing guidelines, as with any other ESLint project. |
|
@JamesHenry sure one sec |
…ve Babel Convert to ES6 that is supported on Node 4, commonjs modules and remove Babel Remove babel task from gulpfile Switch main to src/lib.js Remove node body check
…ve Babel Convert to ES6 that is supported on Node 4, commonjs modules and remove Babel Remove babel task from gulpfile Switch main to src/lib.js Remove node body check Convert to ES6 that is supported on Node 4, commonjs modules and remove Babel Remove babel task from gulpfile Switch main to src/lib.js Remove node body check
|
@corbinu In the future, may you please update an existing PR rather than closing/recreating a new PR every time a change is requested? It makes things much easier to review when all the comments are in one place. |
|
@not-an-aardvark Yes I am sorry I was having trouble getting the rebase to work after mistakenly merging |
3 participants
Lets try this one more time
This removes Babel, converts to commonjs modules and removes other ES6 features not supported on Node 4. I think it was all destructuring.
Updated version of #8 which removes .defaults and rebased on master