Add SKIP-RX-COPY support - using MSG_TRUNC socket option#1717
Merged
swlars merged 4 commits intoesnet:masterfrom Apr 25, 2025
Merged
Add SKIP-RX-COPY support - using MSG_TRUNC socket option#1717swlars merged 4 commits intoesnet:masterfrom
swlars merged 4 commits intoesnet:masterfrom
Conversation
Contributor
|
Thanks for the pull request! We saw some improvements using this flag! |
swlars
reviewed
Apr 25, 2025
|
|
||
| /********************************************************************/ | ||
| /* reads 'count' bytes from a socket - but without using select() */ | ||
| /* Nreads 'count' bytes from a socket - but without using select() */ |
Contributor
There was a problem hiding this comment.
This was my add for testing, we're probably going to re-evaluate how this all works in the near future, this was not the optimal solution but it seems to work for now.
swlars
approved these changes
Apr 25, 2025
Contributor
swlars
left a comment
swlars
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the pull request!
bmah888
added a commit
that referenced
this pull request
May 2, 2025
* Add an entry in the manual page for --skip-rx-copy * Re-sort command-line flag constants in src/iperf_api.h
coolshou
pushed a commit
to coolshou/iperf
that referenced
this pull request
Jun 6, 2025
* Add an entry in the manual page for --skip-rx-copy * Re-sort command-line flag constants in src/iperf_api.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version of iperf3 (or development branch, such as
masteror3.1-STABLE) to which this pull request applies:master
Issues fixed (if any):
feature request: support for MSG_ZEROCOPY and MSG_TRUNC flags #1678 (partially)
Brief description of code changes (suitable for use as a commit message):
Add SKIP-RX-COPY support - using MSG_TRUNC socket option to UDP and TCP. This is a subset of the original PR #1690 that originally supported both skip-rx-copy and zerocopy for UDP. Because of UDP related issues found by @MattCatz, I split the handling of the two solutions into two PRs.
The added option is
--skip-rx-copy: for both TCP and UDP,recv(..., MSG_TRUNC)is used instead ofread().After the changes suggested by @MattCatz the PR code is mature enough.
(Note that running bootstrap.sh; configure is required before make to support the new features.)
Note that whether the feature enhance performance seems to depend on the test environment. However, th e support for the feature also allows to test its impact in the specific environment.