JSON_Read() warning messages enhancements#1817
Merged
bmah888 merged 2 commits intoesnet:masterfrom Jan 27, 2025
Merged
Conversation
bmah888
requested changes
Jan 6, 2025
Contributor
bmah888
left a comment
bmah888
left a comment
There was a problem hiding this comment.
Thanks for the PR! Just one quick comment so far: it'd probably be better to use snprintf() rather than sprintf() in this patch to limit the number of bytes that get written into msg_buf. So maybe something like snprintf(msg_buf, sizeof(msg_buf), ...
The chance of overflowing msg_buf with the current code is probably zero, but the use of snprintf(3) is generally discouraged and I think some compilers will warn about its usage.
Contributor
Author
Changed |
bmah888
approved these changes
Jan 27, 2025
Contributor
|
Thanks again! Tested this with normal iperf3 operation, as well as some scripts that simulate abnormal operation. Going to do a squash and merge shortly. |
swlars
pushed a commit
that referenced
this pull request
Apr 25, 2025
* JSON_Read() warning messages enhancements * Change sprintf() to snprintf() per reviewer comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version of iperf3 (or development branch, such as
masteror3.1-STABLE) to which this pull request applies:master
Issues fixed (if any): none
Brief description of code changes (suitable for use as a commit message):
Enhancement to the
JSON_Read()warning()messages done while evaluating issue iperf3: error - unable to receive parameters from client: Bad file descriptor #1808. I believe that they can help in other situations.