Fix for 3 minor issues (unrelated to each other)

[davidBar-On]

• Version of iperf3 (or development branch, such as master or
  3.1-STABLE) to which this pull request applies:
  master

• Issues fixed (if any): none

• Brief description of code changes (suitable for use as a commit message):

Fix 3 minor issues that are unrelated to each other, but decided to put them in the same PR to save number of PRs. Issues are:

1. iperf_api.c: allow server to store received data in file.
2. iperf_error.c: add missing case for IETOTALINTERVAL.
3. iperf_locale.c: fix copy/paste error ("bytes" instead of "blocks").

[bmah888]

Thanks for the PR! We'll take a look.

[bmah888]

Thanks for the PR! At this point, two of the three fixes in this PR look good to me by visual inspection (have not done much testing with the yet, although I see how to recreate the bugs that they fix). The change having to do with file transfers over UDP, I am having some trouble understanding. Could you help me understand what iperf3 is doing wrong and how the change fixes it?

[davidBar-On]

This is a change I would have applied on top of your original PR to fix the logic conditions (but doesn't try to pass errors from the client back to the server). I'm playing with this a bit, and also thinking about your control channel enhancement.

OK. made the changes as suggested and removed the passing the error code from the server to the client.

Submitter PR #1932 with a suggest server to client error passing (a simpler implementation since in my previous suggestion here I overlooked the SERVER_ERROR state.)

[bmah888]

Thanks for working with me on various comments! Approved.