Skip to content

adding tcp_info support for MacOS#2008

Merged
bmah888 merged 4 commits intoesnet:masterfrom
bucweat:mac-tcpinfo
Mar 6, 2026
Merged

adding tcp_info support for MacOS#2008
bmah888 merged 4 commits intoesnet:masterfrom
bucweat:mac-tcpinfo

Conversation

@bucweat
Copy link
Contributor

@bucweat bucweat commented Feb 24, 2026

PLEASE NOTE the following text from the iperf3 license. Submitting a
pull request to the iperf3 repository constitutes "[making]
Enhancements available...publicly":

You are under no obligation whatsoever to provide any bug fixes, patches, or
upgrades to the features, functionality or performance of the source code
("Enhancements") to anyone; however, if you choose to make your Enhancements
available either publicly, or directly to Lawrence Berkeley National
Laboratory, without imposing a separate written license agreement for such
Enhancements, then you hereby grant the following license: a non-exclusive,
royalty-free perpetual license to install, use, modify, prepare derivative
works, incorporate into other computer software, distribute, and sublicense
such enhancements or derivative works thereof, in binary and source code form.

The complete iperf3 license is available in the LICENSE file in the
top directory of the iperf3 source tree.

  • Version of iperf3 (or development branch, such as master or
    3.1-STABLE) to which this pull request applies: master

  • Issues fixed (if any): add tcp_info support for Mac OS (well really tcp_connection_info)

  • Brief description of code changes (suitable for use as a commit message):
    add tcp_info support for Mac OS (well really tcp_connection_info)

@bucweat
Copy link
Contributor Author

bucweat commented Feb 24, 2026

This is my first attempt at pull request here. I believe I made the necessary changes to support "tcp_info", but quite possible I missed something. It builds and runs here, and I get Retr column. I have not tried configure and build yet. Looking for more eyes to verify everything is valid hence pull request.

@bucweat
Copy link
Contributor Author

bucweat commented Feb 24, 2026

fixes #1411

@davidBar-On
Copy link
Contributor

Looking for more eyes to verify everything is valid hence pull request.

I don't have a way to test the changes, but except for two minor comments they look good to me.

@bucweat
Copy link
Contributor Author

bucweat commented Feb 26, 2026

Looking for more eyes to verify everything is valid hence pull request.

I don't have a way to test the changes, but except for two minor comments they look good to me.

Thanks for the eyes on...and sorry for the turds...now [hopefully] removed.

Have you tried GitHub actions for building and testing?

@bucweat
Copy link
Contributor Author

bucweat commented Feb 26, 2026

Have you tried GitHub actions for building and testing?

Never mind I see there is a build.yml. I had to update so I could trigger manually, but looks like everything is going green...at least in my fork. I guess you have the option to approve the build.yml workflow for this pull request...

@bmah888 bmah888 self-assigned this Mar 2, 2026
@bmah888
Copy link
Contributor

bmah888 commented Mar 2, 2026

Thanks for the pull request and thanks @davidBar-On for the reviews so far. We'll take a look at it.

Copy link
Contributor

@bmah888 bmah888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@bmah888 bmah888 merged commit 14db56a into esnet:master Mar 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants