Build esp-hal for the ESP32-P4 in CI#1370
Merged
MabezDev merged 2 commits intoesp-rs:mainfrom Apr 1, 2024
Merged
Conversation
MabezDev
approved these changes
Apr 1, 2024
Member
MabezDev
left a comment
MabezDev
left a comment
There was a problem hiding this comment.
Makes complete sense, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been a couple changes introduced which broke the build for this chip, so even though we're not prioritizing it right now we should at least make sure it doesn't fall into disrepair, as there is essentially no maintenance burden involved in doing so.
I'm only building
esp-halwith theesp32p4feature enabled, MSRV/Clippy/etc. checks are not being performed at this time, as this will likely cause annoyances.