Warn users when attempting to build esp-hal using the dev profile#1420
Merged
jessebraham merged 2 commits intoesp-rs:mainfrom Apr 11, 2024
Merged
Warn users when attempting to build esp-hal using the dev profile#1420jessebraham merged 2 commits intoesp-rs:mainfrom
esp-hal using the dev profile#1420jessebraham merged 2 commits intoesp-rs:mainfrom
Conversation
Member
SergioGasquez
left a comment
SergioGasquez
left a comment
There was a problem hiding this comment.
Changes LGTM! Shall we close #1261 with this PR or shall we leave it open until it's properly documented in other places?
Member
Author
Those other places have nothing to do with this repository so I don't see any reason to keep it open. |
SergioGasquez
approved these changes
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Happy to hear any input with regards to wording here, but I think this should be adequate.
Closes #1261, however we should open tracking issues for any other repos which still need updating.