Add the esp-ieee802154 package to the repository#1554
Merged
jessebraham merged 2 commits intoesp-rs:mainfrom May 15, 2024
Merged
Add the esp-ieee802154 package to the repository#1554jessebraham merged 2 commits intoesp-rs:mainfrom
esp-ieee802154 package to the repository#1554jessebraham merged 2 commits intoesp-rs:mainfrom
Conversation
Contributor
|
Nice to have the examples in the examples folder like all the other examples 👍 I wonder what to do about the sniffer (both on target and Wireshark code) 🤔 |
MabezDev
reviewed
May 15, 2024
bjoernQ
approved these changes
May 15, 2024
Contributor
bjoernQ
left a comment
bjoernQ
left a comment
There was a problem hiding this comment.
LGTM - we can figure out what to do about the Wireshark plugins afterwards
MabezDev
approved these changes
May 15, 2024
burrbull
reviewed
May 15, 2024
| let mut format_char = ' '; | ||
| let mut is_long = false; | ||
| let mut found = false; | ||
| for c in s.chars() { |
Contributor
There was a problem hiding this comment.
Is this ascii or utf-8? If ascii then better to use bytes instead of chars.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.