Add the esp-println package to the repository#1575
Conversation
bjoernQ
left a comment
There was a problem hiding this comment.
LGTM - Thanks for taking care of this!
|
I'm wondering how we could best deal with CI in future? I guess we could run CI for a crate only if something changed in the path but I'm not sure how that works with HIL tests |
SergioGasquez
left a comment
There was a problem hiding this comment.
LGTM! Left one nitpick suggestion that can be ignored.
This would be very helpful, but we might need to do some tests, as the “required tests” feature of GH works weird. |
Whilst I do like the idea in principle, I think simple is better. The main contributions to CI time are esp-hal (and will be esp-wifi too), the other crates compile in a few seconds usually. Happy to explore it if we can find a robust way to do it though. |
Co-authored-by: Sergio Gasquez Arcos <sergio.gasquez@gmail.com>
|
Hmm, new clippy lint 😫. I think I'm just gonna force merge this and we can deal with it in a different PR. |
No changes to the library itself were made. The build script was updated to use
esp-build, however the behaviour remains the same.I have not updated
README.mdat all other than fixing the paths to the license files, since this is used in the docs. This can be updated as needed in a subsequent PR.A patch is temporarily required for the
examples/package, untilesp-backtracegets added as well; I will take care of all that once this PR is merged.Once this is merged I will transfer any relevant issues and archive the old
esp-printlnrepository.