⬆️ update bindgen to latest version#304
Merged
Vollbrecht merged 3 commits intoesp-rs:masterfrom May 27, 2024
Merged
Conversation
Collaborator
|
I assume we can only do this once we update the |
Collaborator
Author
We already bumped the bindgen version in embuild on master some time ago, but yes both versions need to be the same to work. Though no additional specif work is needed as far as i can see. Only if we want to use some of the newer features that were introduced. |
Collaborator
Author
|
as discussed in matrix we will point esp-idf-sys master to embuild git master, so we can test if it works on any platform. |
Collaborator
|
The problem is, now you need to multiply this [patch.crates-io] section in all crates. Well, if we had workspace build, then... you know what I'll say. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changelog of bindgen added a lot between 0.63 and 0.69 though it still seams to work without any problems. They introduces some new features that may be interesting in the future - like creating bindgens for C functions that are inlined in the api and thus currently not producing any bindgen output etc.
This change is also needed when esp-rs/embuild#85 lands so we have version parity between both