Skip to content

Add String::concat(char*, len) to allow non null-term strings#6754

Merged
d-a-v merged 3 commits into
esp8266:masterfrom
earlephilhower:concat-non-cste
Nov 13, 2019
Merged

Add String::concat(char*, len) to allow non null-term strings#6754
d-a-v merged 3 commits into
esp8266:masterfrom
earlephilhower:concat-non-cste

Conversation

@earlephilhower

Copy link
Copy Markdown
Collaborator

Fixes #5061

Adds a concat(const char *data, int len) method which allows arbitrary
sequences of data (including ones w/embedded \0s) to be appended to a
String. May be useful for certain MQTT operations.

Adds sanity test for the feature to host suite

Fixes esp8266#5061

Adds a concat(const char *data, int len) method which allows arbitrary
sequences of data (including ones w/embedded \0s) to be appended to a
String.  May be useful for certain MQTT operations.

Adds sanity test for the feature to host suite
@earlephilhower earlephilhower changed the title Add comcat(char*, len) to Sting Add concat(char*, len) to Sting Nov 11, 2019
Comment thread tests/host/core/test_string.cpp Outdated
Comment thread tests/host/core/test_string.cpp Outdated
Comment thread tests/host/core/test_string.cpp Outdated
@earlephilhower earlephilhower changed the title Add concat(char*, len) to Sting Add concat(char*, len) to String Nov 11, 2019
@devyte devyte changed the title Add concat(char*, len) to String Add String::concat(char*, len) to allow non null-term strings Nov 13, 2019
@devyte devyte added this to the 2.6.1 milestone Nov 13, 2019
@d-a-v d-a-v merged commit 09896d5 into esp8266:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

request to modify String::concat

3 participants