Remove memory leak on multiple calls to initCertStore#7021
Merged
earlephilhower merged 3 commits intoesp8266:masterfrom Jan 17, 2020
Merged
Remove memory leak on multiple calls to initCertStore#7021earlephilhower merged 3 commits intoesp8266:masterfrom
earlephilhower merged 3 commits intoesp8266:masterfrom
Conversation
In some cases, `initCertStore` may need to be called multiple times (i.e. to update certs w/oa reboot). In that case, the saved file names leaked when the new ones were `malloc()`'d. Fix by freeing the old strings, if present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases,
initCertStoremay need to be called multiple times(i.e. to update certs w/oa reboot). In that case, the saved file names
leaked when the new ones were
malloc()'d.Fix by freeing the old strings, if present.