Skip to content

Fix: SD_MMC deinit#5732

Merged
me-no-dev merged 3 commits intoespressif:masterfrom
P-R-O-C-H-Y:master
Oct 9, 2021
Merged

Fix: SD_MMC deinit#5732
me-no-dev merged 3 commits intoespressif:masterfrom
P-R-O-C-H-Y:master

Conversation

@P-R-O-C-H-Y
Copy link
Copy Markdown
Member

@P-R-O-C-H-Y P-R-O-C-H-Y commented Oct 4, 2021 •
edited
Loading

Summary

Fixed wrong deinit called in SD_MMC lib. The SD_MMC deinit was callid SPI deinit instead of MMC deinit.

Issue #5195
Issue #5368
Issue #5739

Impact

No impact.

@P-R-O-C-H-Y
SD.open() new feature for creating all folders in path
82667e8 
This PR adds to the SD.open() function option to create all folders to the file.

SD.open(const char* path, const char* mode, const bool create)

Default value of create is false.
When true folders are created.

From issue #5019
@P-R-O-C-H-Y
Update vfs_api.cpp
40e1cc4 
memccpy -> memcpy
@P-R-O-C-H-Y
SD_MMC deinit fix
f069632 
Wrong deinit function was called.
@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Oct 4, 2021
@P-R-O-C-H-Y P-R-O-C-H-Y mentioned this pull request Oct 8, 2021
Closed
@me-no-dev me-no-dev merged commit 5b20710 into espressif:master Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@me-no-dev me-no-dev Awaiting requested review from me-no-dev

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@P-R-O-C-H-Y @me-no-dev