add support for WS2811 timing (IEC-194)#402
Merged
suda-morris merged 2 commits intoespressif:masterfrom Oct 27, 2024
Merged
Conversation
Collaborator
Contributor
Author
A little overkill, but I am fine whatever you decide. My WS2811 timing changes are pretty small and independent of the RGB vs GRB handling. Should I revert my RGB changes? |
Collaborator
WS8211 timing changes
Contributor
Author
suda-morris
approved these changes
Oct 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
Within the led_strips component:
Added a new led model in led_strip_types
Added the corresponding timing in led_strip_rmt_encoder (I had to move reset_ticks definition up to be able to edit it for WS2811
Source: https://cdn-shop.adafruit.com/datasheets/WS2811.pdf
or https://www.alldatasheet.com/datasheet-pdf/view/1132633/WORLDSEMI/WS2811.html
I tested on a WS2811 50 led strip
Note WS2811 is RGB, not GRB. I will put that change in later