feat: Macronix Flash memory support#713
Open
Sotilrac wants to merge 9 commits intoespressif:masterfrom
Open
Conversation
|
|
Author
|
Hi, Let me know if you need any input from me or if I need to do anything to trigger the automated checks. |
…35LF2GE4AD # Conflicts: # spi_nand_flash/CMakeLists.txt # spi_nand_flash/priv_include/nand_flash_chip.h # spi_nand_flash/priv_include/nand_flash_devices.h # spi_nand_flash/src/nand.c
The override_path: '../dhara' assumes spi_nand_flash is checked out
inside the idf-extra-components monorepo where dhara lives as a sibling.
When the component is fetched alone via a git source in idf_component.yml
(e.g. "espressif/spi_nand_flash: { git: ..., path: spi_nand_flash }"),
ESP-IDF Component Manager places it in a temp directory by itself,
and ../dhara doesn't resolve.
Removing the override lets the manager pull dhara from the registry
via the existing version constraint. Sibling-directory builds still
work since the registry lookup succeeds either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
urlfield definedChange description
Adds support for Macronix FLASH memory. Tested with ESP-C6-MINI-N4 and MX35LF2GE4AD.