feat: add IQmath format support for pid_ctrl (IEC-513)#719
Open
Vorrad wants to merge 1 commit intoespressif:masterfrom
Open
feat: add IQmath format support for pid_ctrl (IEC-513)#719Vorrad wants to merge 1 commit intoespressif:masterfrom
Vorrad wants to merge 1 commit intoespressif:masterfrom
Conversation
72b8680 to
95e8b64
Compare
Collaborator
|
Did you consider using the https://www.runoob.com/w3cnote/c-general-function.html?utm_source=copilot.com |
95e8b64 to
cf4097c
Compare
suda-morris
reviewed
Apr 24, 2026
| default n | ||
| help | ||
| When enabled, pid_ctrl exposes a second set of *_iq APIs using | ||
| Espressif IQmath. The float and IQ backends can be used in the |
Collaborator
There was a problem hiding this comment.
如果iq版本和float版本可以共存,为什么还需要这个Kconfig?
suda-morris
reviewed
Apr 24, 2026
| @@ -1,4 +1,6 @@ | |||
| set(srcs "src/pid_ctrl.c") | |||
| set(requires "iqmath") | |||
Collaborator
There was a problem hiding this comment.
应该不需要了,已经通过idf_component.yml注入了依赖了
Contributor
Author
There was a problem hiding this comment.
测试下来不加会报错。之前也遇到过这种情况,idf_component.yml的依赖没有成功被添加。
cf4097c to
9fd445f
Compare
9fd445f to
fcb71b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
urlfield definedChange description
Please describe your change here