Skip to content

fix(alerts): align etcdHighNumberOfFailedProposals description with rate window - #22324

Open
prithvipatil97 wants to merge 1 commit into
etcd-io:mainfrom
prithvipatil97:fix/etcdHighNumberOfFailedProposals-description
Open

fix(alerts): align etcdHighNumberOfFailedProposals description with rate window#22324
prithvipatil97 wants to merge 1 commit into
etcd-io:mainfrom
prithvipatil97:fix/etcdHighNumberOfFailedProposals-description

Conversation

@prithvipatil97

@prithvipatil97 prithvipatil97 commented Aug 21, 2026

Copy link
Copy Markdown

What

The etcdHighNumberOfFailedProposals alert description said proposal failures occurred within the last 30 minutes, but:

  • expr uses rate(...[15m])
  • for is 15m

So the description matched neither the PromQL window that produces {{ $value }} nor the pending duration.

Fix

Update the description only: 30 minutes15 minutes (same pattern as etcdHighNumberOfLeaderChanges, which already says “last 15 minutes” for its 15m window).

No changes to expression, for, severity, or summary.

Why

Misleading for operators reading the alert in consoles / Alertmanager. OpenShift inherits this mixin via cluster-etcd-operator.

Tracked for OpenShift as OCPBUGS-105285.

Test plan

  • Diff is description-only
  • rate(...[15m]) and for: 15m unchanged

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prithvipatil97
Once this PR has been reviewed and has the lgtm label, please assign fuweid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow

Copy link
Copy Markdown

Hi @prithvipatil97. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

…ate window

The description said proposal failures were within the last 30 minutes, but
the value comes from rate(...[15m]) and for is also 15m. Update the wording
to 15 minutes so it matches the PromQL window.

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: prithvipatil97 <pripatil@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@prithvipatil97
prithvipatil97 force-pushed the fix/etcdHighNumberOfFailedProposals-description branch from 64e9831 to b6d6b44 Compare August 21, 2026 13:15
@prithvipatil97

Copy link
Copy Markdown
Author

Hello @ahrtr , @ivanvc ,
Good Morning.

I need your attention here.
This is a small fix in the etcd mixin alert etcdHighNumberOfFailedProposals.
The alert description currently says 30 minutes, but both the PromQL window and for are 15 minutes. Kindly check the Jira OCPBUGS-105285 for more information. I have submitted this PR with the fix.

Could you please help with /ok-to-test and an approval review when you get a chance?

This is the upstream PR, After it merges, I will open a follow-up PR in OpenShift cluster-etcd-operator to vendor this update.

Thank you in advance.

Regards,
Prithviraj Patil.

@ahrtr

ahrtr commented Aug 24, 2026

Copy link
Copy Markdown
Member

/ok-to-test

cc @v-zhuravlev

@kubernetes-prow

Copy link
Copy Markdown

@prithvipatil97: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-e2e-386 b6d6b44 link true /test pull-etcd-e2e-386

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.73%. Comparing base (c34dc7e) to head (b6d6b44).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

see 15 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #22324      +/-   ##
==========================================
- Coverage   69.75%   69.73%   -0.02%     
==========================================
  Files         448      448              
  Lines       38159    38159              
==========================================
- Hits        26618    26612       -6     
- Misses      10110    10116       +6     
  Partials     1431     1431              

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c34dc7e...b6d6b44. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fuweid fuweid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Cursor cursoragent@cursor.com

Please remove this. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants