fix(alerts): align etcdHighNumberOfFailedProposals description with rate window - #22324
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: prithvipatil97 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @prithvipatil97. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…ate window The description said proposal failures were within the last 30 minutes, but the value comes from rate(...[15m]) and for is also 15m. Update the wording to 15 minutes so it matches the PromQL window. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: prithvipatil97 <pripatil@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
64e9831 to
b6d6b44
Compare
|
Hello @ahrtr , @ivanvc , I need your attention here. Could you please help with /ok-to-test and an approval review when you get a chance? This is the upstream PR, After it merges, I will open a follow-up PR in OpenShift cluster-etcd-operator to vendor this update. Thank you in advance. Regards, |
|
/ok-to-test cc @v-zhuravlev |
|
@prithvipatil97: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 15 files with indirect coverage changes @@ Coverage Diff @@
## main #22324 +/- ##
==========================================
- Coverage 69.75% 69.73% -0.02%
==========================================
Files 448 448
Lines 38159 38159
==========================================
- Hits 26618 26612 -6
- Misses 10110 10116 +6
Partials 1431 1431 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
fuweid
left a comment
There was a problem hiding this comment.
Co-authored-by: Cursor cursoragent@cursor.com
Please remove this. Thanks
What
The
etcdHighNumberOfFailedProposalsalert description said proposal failures occurred within the last 30 minutes, but:exprusesrate(...[15m])foris15mSo the description matched neither the PromQL window that produces
{{ $value }}nor the pending duration.Fix
Update the description only:
30 minutes→15 minutes(same pattern asetcdHighNumberOfLeaderChanges, which already says “last 15 minutes” for its 15m window).No changes to expression,
for, severity, or summary.Why
Misleading for operators reading the alert in consoles / Alertmanager. OpenShift inherits this mixin via cluster-etcd-operator.
Tracked for OpenShift as OCPBUGS-105285.
Test plan
rate(...[15m])andfor: 15munchanged