eip7732: add fork choice tests (part1)#4489
Closed
terencechain wants to merge 1 commit intoethereum:masterfrom
Closed
eip7732: add fork choice tests (part1)#4489terencechain wants to merge 1 commit intoethereum:masterfrom
terencechain wants to merge 1 commit intoethereum:masterfrom
Conversation
terencechain
force-pushed
the
fc-tests-base
branch
2 times, most recently
from
627ddb7 to
14832ac
Compare
terencechain
force-pushed
the
fc-tests-base
branch
from
14832ac to
ff21729
Compare
Member
|
@terencechain we should avoid name clashes of tests even if they are in different files, I think pytest can confuse them in reports and thinks like that, so please put a longer more descriptive name for the tests. |
jtraglia
changed the title
jtraglia
reviewed
Sep 11, 2025
| # --------------------------------------------------------------- | ||
| # 2**1(= 2) | ||
| PTC_SIZE: 2 | ||
| # 2**3(= 8) |
Member
There was a problem hiding this comment.
Nit: let's fix this too while we're at it.
Suggested change
| # 2**3(= 8) | |
| # 2**3 (= 8) |
3 tasks
3 tasks
3 tasks
18 tasks
16 tasks
21 tasks
Member
|
This PR is very stale. Let's close it and restart. cc @leolara |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.