feat(tests): add test for CLZ opcode with varying gas costs #1859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouisTsai-Csie
added
fork:osaka
25 tasks
spencer-tb
reviewed
Jul 4, 2025
Collaborator
spencer-tb
left a comment
spencer-tb
left a comment
There was a problem hiding this comment.
Thanks! Just some small changes. I wondered if it was worth combining this test with test_clz_gas initially, but happy to have this as its own case.
Could we also rename test_clz_gas to test_clz_gas_cost?
tests/osaka/eip7939_count_leading_zeros/test_count_leading_zeros.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7939_count_leading_zeros/test_count_leading_zeros.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7939_count_leading_zeros/test_count_leading_zeros.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7939_count_leading_zeros/test_count_leading_zeros.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7939_count_leading_zeros/test_count_leading_zeros.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7939_count_leading_zeros/test_count_leading_zeros.py
Outdated
Show resolved
Hide resolved
tests/osaka/eip7939_count_leading_zeros/test_count_leading_zeros.py
Outdated
Show resolved
Hide resolved
Collaborator
Author
I explored this idea before implementation, but based on my understanding, the |
spencer-tb
added
scope:tests
LouisTsai-Csie
force-pushed
the
clz-gas-cost
branch
2 times, most recently
from
b9ca764 to
1313b65
Compare
LouisTsai-Csie
force-pushed
the
clz-gas-cost
branch
from
1313b65 to
b0433ff
Compare
Collaborator
|
Thanks for updating and the comment @jochem-brouwer! |
kclowes
pushed a commit
to kclowes/execution-spec-tests
that referenced
this pull request
Oct 20, 2025
…#1859) * feat(tests): add test for CLZ opcode with varying gas costs * refactor(tests): rename and update CLZ gas cost test to handle boundary conditions * refactor(tests): rename CLZ gas cost test for clarity * refactor(tests): parameterize for varying leading zero lengths * refactor(tests): update contract deployment to include storage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Add different gas cost test cases for CLZ opcode
🔗 Related Issues or PRs
Issue #1795
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.