-
Notifications
You must be signed in to change notification settings - Fork 412
feat(test-execute): tx batching for execute remote #1907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(test-execute): tx batching for execute remote #1907
Conversation
cc82819 to
f5aba6d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #1907 +/- ##
================================================
Coverage 86.26% 86.26%
================================================
Files 538 538
Lines 34557 34557
Branches 3222 3222
================================================
Hits 29809 29809
Misses 4161 4161
Partials 587 587
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3d2eede to
9e161b6
Compare
f5aba6d to
ab2748f
Compare
ab2748f to
588a3f0
Compare
marioevz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some improvement suggestions.
packages/testing/src/execution_testing/execution/transaction_post.py
Outdated
Show resolved
Hide resolved
packages/testing/src/execution_testing/execution/transaction_post.py
Outdated
Show resolved
Hide resolved
packages/testing/src/execution_testing/cli/pytest_commands/plugins/execute/execute.py
Show resolved
Hide resolved
692c084 to
5029be9
Compare
5029be9 to
ec8d907
Compare
…thereum#1907) Convert absolute imports to relative imports within the same package Changes affect: * CLI components (eest, eofwrap) * Test files across all packages * Pytest plugin components (consume, execute, filler) * Framework utility modules
…thereum#1907) Convert absolute imports to relative imports within the same package Changes affect: * CLI components (eest, eofwrap) * Test files across all packages * Pytest plugin components (consume, execute, filler) * Framework utility modules
marioevz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
🗒️ Description
Benchmark PR #1885 introduces approximately 15,000 funding transactions. Currently, the execute-remote mode aggregates all transactions and submits them at once, which causes issues since the RPC endpoint cannot handle such workload. Based on current testing, a local node can now reliably handle up to around 1000 transactions.
Solution
🔗 Related Issues or PRs
None
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture