Skip to content

Conversation

@LouisTsai-Csie
Copy link
Collaborator

@LouisTsai-Csie LouisTsai-Csie commented Dec 12, 2025

🗒️ Description

Benchmark PR #1885 introduces approximately 15,000 funding transactions. Currently, the execute-remote mode aggregates all transactions and submits them at once, which causes issues since the RPC endpoint cannot handle such workload. Based on current testing, a local node can now reliably handle up to around 1000 transactions.

Solution

  • Transactions are now sent in configurable batches (default: 750 transactions per batch).
  • Each batch is submitted and confirmed before the next batch is sent.
  • Progress logging reports the batch number and transaction ranges.
  • A warning is emitted when the batch size exceeds 1,000 transactions (the safe threshold).

🔗 Related Issues or PRs

None

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Gemini_Generated_Image_fgwqy6fgwqy6fgwq

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.26%. Comparing base (806fd80) to head (ec8d907).
⚠️ Report is 28 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #1907   +/-   ##
================================================
  Coverage            86.26%   86.26%           
================================================
  Files                  538      538           
  Lines                34557    34557           
  Branches              3222     3222           
================================================
  Hits                 29809    29809           
  Misses                4161     4161           
  Partials               587      587           
Flag Coverage Δ
unittests 86.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LouisTsai-Csie LouisTsai-Csie self-assigned this Dec 16, 2025
@LouisTsai-Csie LouisTsai-Csie added A-test-benchmark Area: execution_testing.benchmark and tests/benchmark A-test-execute Area: execution_testing.cli.pytest_commands.plugins.execute C-feat Category: an improvement or new feature and removed A-test-benchmark Area: execution_testing.benchmark and tests/benchmark labels Dec 16, 2025
@LouisTsai-Csie LouisTsai-Csie changed the title Execute rate limit feat(test-cli-execute): tx batching for execute remote Dec 16, 2025
@LouisTsai-Csie LouisTsai-Csie marked this pull request as ready for review December 16, 2025 05:07
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some improvement suggestions.

@LouisTsai-Csie LouisTsai-Csie changed the title feat(test-cli-execute): tx batching for execute remote feat(test-execute): tx batching for execute remote Dec 22, 2025
Carsons-Eels pushed a commit to Carsons-Eels/execution-specs that referenced this pull request Jan 6, 2026
…thereum#1907)

Convert absolute imports to relative imports within the same package

Changes affect:

* CLI components (eest, eofwrap)
* Test files across all packages
* Pytest plugin components (consume, execute, filler)
* Framework utility modules
Carsons-Eels pushed a commit to Carsons-Eels/execution-specs that referenced this pull request Jan 6, 2026
…thereum#1907)

Convert absolute imports to relative imports within the same package

Changes affect:

* CLI components (eest, eofwrap)
* Test files across all packages
* Pytest plugin components (consume, execute, filler)
* Framework utility modules
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit 9aefc86 into ethereum:forks/amsterdam Jan 12, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-execute Area: execution_testing.cli.pytest_commands.plugins.execute C-feat Category: an improvement or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants