feat(benchmarks): add BAL contract chase#2588
Draft
jochem-brouwer wants to merge 1 commit intoethereum:forks/amsterdamfrom
Draft
feat(benchmarks): add BAL contract chase#2588jochem-brouwer wants to merge 1 commit intoethereum:forks/amsterdamfrom
jochem-brouwer wants to merge 1 commit intoethereum:forks/amsterdamfrom
Conversation
2 tasks
d35efe5 to
3e67566
Compare
3e67566 to
d395cfe
Compare
Member
Author
|
CCing this comment from @fselmo here:
I tested this on a gas limit of 1M and this executed ~470k gas, so this might be part of the problem (txs not using full cap) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2588 +/- ##
================================================
Coverage 86.35% 86.35%
================================================
Files 599 599
Lines 36904 36904
Branches 3771 3771
================================================
Hits 31868 31868
Misses 4485 4485
Partials 551 551
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This test re-introduces the contract chase benchmark in #2033 which looks wrong there. The current status is that this appears to consume about 47% of the gas it has available. Since we want to bench using most of the available gas this is something to look into to find out if we can spend this on something else in this benchmark.
Note: builds on #2033, merge that prior to merging this.
🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture