This repository was archived by the owner on May 16, 2020. It is now read-only.
qcommon: fix potential buffer overflow in COM_StripFilename#350
Open
Exagone313 wants to merge 2 commits into
Open
qcommon: fix potential buffer overflow in COM_StripFilename#350Exagone313 wants to merge 2 commits into
Exagone313 wants to merge 2 commits into
Conversation
Contributor
|
Probably better to rewrite it with buffer size in parameter list and possibly use strrchr for \ and / depending on platform or if its a qpath then you can do / only. |
Exagone313
force-pushed
the
fix-strncpy-warning
branch
from
3eb7e8f to
120d8c6
Compare
Exagone313
force-pushed
the
fix-strncpy-warning
branch
from
120d8c6 to
4c3c646
Compare
Contributor
Author
|
Updated prototype of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a potential buffer overflow and a compilation warning (
warning: ‘strncpy’ specified bound depends on the length of the source argument [-Wstringop-overflow=]).The COM_StripFilename function is only used once on a
MAX_QPATHsized char array.Also saw that Q_strncpyz function uses strncpy with len-1 and ensures a NUL at len-1 (so it is safe).