Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR significantly improves the documentation for EventFlow's jobs feature by making it clearer, more comprehensive, and better structured. The updates modernize the language, add important warnings about default behavior, and provide more practical guidance.
Key Changes
- Enhanced introduction with clearer explanations of job use cases and EventFlow's job system
- Added critical warnings about the default
InstantJobSchedulerbehavior and serialization requirements - Improved Hangfire integration section with production-ready configuration examples
| .AddHangfireServer(); | ||
| eventFlowOptions.UseHangfireJobScheduler(); | ||
| eventFlowOptions.ServiceCollection | ||
| .AddHangfire(configuration => configuration.UseSqlServerStorage(connectionString)) |
There was a problem hiding this comment.
The connectionString variable is referenced but not defined in the example. Consider either defining it or using a placeholder like \"YourConnectionStringHere\" to make the example more complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.