Skip to content
This repository was archived by the owner on Apr 4, 2024. It is now read-only.

Setup a validator in the test genesis#1171

Merged
fedekunze merged 1 commit intoevmos:mainfrom
yihuang:val_in_unit_test
Jul 11, 2022
Merged

Setup a validator in the test genesis#1171
fedekunze merged 1 commit intoevmos:mainfrom
yihuang:val_in_unit_test

Conversation

@yihuang
Copy link
Copy Markdown

@yihuang yihuang commented Jul 11, 2022

Extracted from: #1168

In cosmos-sdk 0.46's InitGenesis it reject Zero validators,
prepare for the upgrade of cosmos-sdk 0.46.

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

It's disabled in cosmos-sdk 0.46's InitGenesis to have zero validators,
prepare for the upgrade of cosmos-sdk 0.46.
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 11, 2022

Codecov Report

Merging #1171 (e2bd6ff) into main (3d2f72a) will increase coverage by 0.52%.
The diff coverage is 90.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1171      +/-   ##
==========================================
+ Coverage   61.54%   62.06%   +0.52%     
==========================================
  Files          91       91              
  Lines        7281     7355      +74     
==========================================
+ Hits         4481     4565      +84     
+ Misses       2577     2562      -15     
- Partials      223      228       +5     
Impacted Files Coverage Δ
app/utils.go 69.32% <90.78%> (+34.49%) ⬆️
app/app.go 86.00% <0.00%> (+0.44%) ⬆️

@yihuang yihuang mentioned this pull request Jul 11, 2022
11 tasks
Copy link
Copy Markdown
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fedekunze fedekunze merged commit b7c85be into evmos:main Jul 11, 2022
hoanguyenkh pushed a commit to AstraProtocol/ethermint that referenced this pull request Jul 27, 2022
It's disabled in cosmos-sdk 0.46's InitGenesis to have zero validators,
prepare for the upgrade of cosmos-sdk 0.46.
devon-chain pushed a commit to PundiAI/ethermint-old that referenced this pull request Nov 17, 2022
It's disabled in cosmos-sdk 0.46's InitGenesis to have zero validators,
prepare for the upgrade of cosmos-sdk 0.46.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants