enable fraud service to full & light nodes and extend abci.FraudProof with go-fraud Proof interface #891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gupadhyaya
force-pushed
the
fraud_exchange
branch
from
76978a3 to
1defdec
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #891 +/- ##
=========================================
+ Coverage 0 54.67% +54.67%
=========================================
Files 0 68 +68
Lines 0 11011 +11011
=========================================
+ Hits 0 6020 +6020
- Misses 0 4119 +4119
- Partials 0 872 +872
☔ View full report in Codecov by Sentry. |
gupadhyaya
force-pushed
the
fraud_exchange
branch
from
1defdec to
098a781
Compare
nashqueue
added
the
C:state-fraud-proofs
gupadhyaya
force-pushed
the
fraud_exchange
branch
from
5cdab60 to
63f163b
Compare
Manav-Aggarwal
requested changes
May 3, 2023
Member
Manav-Aggarwal
left a comment
Manav-Aggarwal
left a comment
There was a problem hiding this comment.
Thanks for the PR! Left some comments.
Member
Author
this PR only adds fraud-exchange service to full and light nodes and for that the graceful start and stop is already tested in other unit tests. the fraud-exchange functionality will be added in the next PR along with new tests to cover the exchange part. will that suffice? |
tzdybal
previously approved these changes
May 8, 2023
added 2 commits
May 9, 2023 07:35
… with go-fraud Proof interface methods rename to state fraud proof remove new method and force interface binding
This was
linked to
issues
May 9, 2023
tzdybal
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of go-fraud library implementation, this PR adds:
Fixes #892 #893 #894