-
Notifications
You must be signed in to change notification settings - Fork 246
fix: Disable CI/CD linter check with rand library, fix server overlap, and data race issue #916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #916 +/- ##
==========================================
- Coverage 56.11% 55.84% -0.28%
==========================================
Files 66 66
Lines 10705 10709 +4
==========================================
- Hits 6007 5980 -27
- Misses 3830 3858 +28
- Partials 868 871 +3
☔ View full report in Codecov by Sentry. |
|
In my opinion, the PR title and later the commit message should not contain "Resolve" because this PR does not resolve the security warning, it just disables the check. |
9b1272f to
b156632
Compare
Since the |
smuu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #911, resolves #919, resolves #910