Skip to content

🐛 app: misc fixes#1006

Merged
cruzdanilo merged 2 commits intomainfrom
fixes
May 7, 2026
Merged

🐛 app: misc fixes#1006
cruzdanilo merged 2 commits intomainfrom
fixes

Conversation

@dieguezguille
Copy link
Copy Markdown
Member

@dieguezguille dieguezguille commented May 7, 2026

Summary by CodeRabbit

  • Bug Fixes

    • Fixed color styling for card details information on platinum cards.
  • Style

    • Updated spacing in the add funds screen for improved layout consistency.

@dieguezguille dieguezguille self-assigned this May 7, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 7, 2026

🦋 Changeset detected

Latest commit: 8c2785c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0b068989-752e-4310-b382-19a669e9b0e6

📥 Commits

Reviewing files that changed from the base of the PR and between d77c834 and 8c2785c.

📒 Files selected for processing (4)
  • .changeset/eager-spies-sink.md
  • .changeset/some-sites-show.md
  • src/components/add-funds/AddFunds.tsx
  • src/components/card/CardDetails.tsx

Walkthrough

This PR applies two independent bug fixes to the @exactly/mobile package as patch releases: correcting card details text color tokens from unprefixed values to the themed $uiNeutralInversePrimary token across three text elements, and adjusting the add funds provider list spacing token from $s4 to $s3_5.

Changes

UI Styling and Layout Refinements

Layer / File(s) Summary
Theme Token Application
src/components/card/CardDetails.tsx
Text elements for card expiration, CVV, and display name updated to use $uiNeutralInversePrimary instead of the unprefixed uiNeutralInversePrimary when rendering platinum cards.
Layout Spacing Adjustment
src/components/add-funds/AddFunds.tsx
Provider list skeleton loading state rendered in YStack with spacing token adjusted from $s4 to $s3_5.
Release Documentation
.changeset/eager-spies-sink.md, .changeset/some-sites-show.md
Changesets entries document patch version bumps for @exactly/mobile with descriptions of card details color fix and add funds screen spacing unification.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • franm91
  • cruzdanilo
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'misc fixes' is vague and generic, using non-descriptive language that doesn't convey meaningful information about the specific changes in the changeset. Replace the generic 'misc fixes' with a more specific title that describes the primary change, such as 'Fix card details color styling in CardDetails component' or 'Fix card color token and add funds spacing'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes the card details text color by correctly prefixing the theme token and adjusts the layout spacing in the Add Funds component. The review feedback suggests refactoring the repeated color selection logic in CardDetails.tsx into a helper function or variable to ensure consistency and simplify future maintenance.

Comment thread src/components/card/CardDetails.tsx
@sentry
Copy link
Copy Markdown

sentry Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.35%. Comparing base (d77c834) to head (8c2785c).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1006      +/-   ##
==========================================
+ Coverage   72.32%   72.35%   +0.03%     
==========================================
  Files         231      231              
  Lines        8884     8884              
  Branches     2874     2874              
==========================================
+ Hits         6425     6428       +3     
+ Misses       2202     2199       -3     
  Partials      257      257              
Flag Coverage Δ
e2e 69.50% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cruzdanilo cruzdanilo merged commit 8c2785c into main May 7, 2026
13 of 14 checks passed
@cruzdanilo cruzdanilo deleted the fixes branch May 7, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants