Add regular expressions libraries to 'Bob' problem#432
Open
yashrk wants to merge 2 commits intoexercism:mainfrom
Open
Add regular expressions libraries to 'Bob' problem#432yashrk wants to merge 2 commits intoexercism:mainfrom
yashrk wants to merge 2 commits intoexercism:mainfrom
Conversation
booniepepper
approved these changes
Mar 10, 2023
Member
|
This PR also requires a change to the ocaml-test-runner as re2 is not a dependency currently installed there. |
Contributor
|
This is easily solvable without regex. Perhaps this is a change to the String module in later OCaml versions that allow this now? In any case, I am not certain that this relevant now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solving this problem without a good regular expression library is a bit humiliating. =)