Added a very basic reflected light approximation to SecondaryEclipseLightCurve WIP#141
Open
christinahedges wants to merge 3 commits intoexoplanet-dev:mainfrom
Open
Added a very basic reflected light approximation to SecondaryEclipseLightCurve WIP#141christinahedges wants to merge 3 commits intoexoplanet-dev:mainfrom
christinahedges wants to merge 3 commits intoexoplanet-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw there is a WIP to add
SecondaryEclipseLightCurvetoexoplanet, but that it doesn't include reflected/thermal phase curve light. I added a silly approximation to quickly add in a phase curve (just a cosine function), that has alagkeyword to shift the "hotspot" on the planet. This is a silly approximation because it doesn't work when there is a large lag, and it's not calculating the ingress/egress correctly.I assume part of the WIP is to include
starryreflected light. But just for now, because I wanted to useSecondaryEclipseLightCurve, I made this edit, and I thought I'd post it here in case anyone was interested in seeing. Not looking for this to be merged, but if anyone had comments about how to contribute toexoplanetbetter, I'd read them!Here's an example use