Add precompiled iOS dependency preparation support#3556
Open
Add precompiled iOS dependency preparation support#3556
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3556 +/- ##
==========================================
+ Coverage 53.80% 53.92% +0.13%
==========================================
Files 820 822 +2
Lines 34978 35076 +98
Branches 7217 7229 +12
==========================================
+ Hits 18815 18911 +96
- Misses 16072 16078 +6
+ Partials 91 87 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
|
Subscribed to pull request
Generated by CodeMention |
|
I’m not yet experienced with the build tools, but I’ve gone through the PR and as far as i can see it looks good. This is also a test for supporting precompiled frameworks on iOS in EAS build so there will definitely be room for some improvements when we get decent packaging and versioning of these modules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@expo/build-toolsand start preparation when flagged builds enable precompiled modulespod installin both build-tools pod flowsTesting