check for the right algorithm after negotiation#32
Closed
hex7c0 wants to merge 1 commit intoexpressjs:masterfrom
Closed
check for the right algorithm after negotiation#32hex7c0 wants to merge 1 commit intoexpressjs:masterfrom
hex7c0 wants to merge 1 commit intoexpressjs:masterfrom
Conversation
remove ternary operator and use if...else
dougwilson
force-pushed
the
master
branch
3 times, most recently
from
d7bb81b to
cd957aa
Compare
Member
|
Thanks for the PR. This is unnecessary - negotiator only returns the encodings we explicitly support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP for #27