response: add support for ETag option in res.sendFile#6073
response: add support for ETag option in res.sendFile#6073wesleytodd merged 1 commit intoexpressjs:masterfrom
Conversation
|
Can we make a test that ensure the that the Etag option is added by deafult? This will help us to document this change and to avoid regressions in the future. Currently we don't include etag, so we should consider this as a minor or a major change? |
UlisesGascon
requested review from
blakeembrey,
ctcpip,
jonchurch and
wesleytodd
Etag is included by default. In the upper tests, you'll see that validation. See Line 65 in a46cfdc
We do, for sendFIle, this patch will make express aware that even on sendFile, it should not ignore the Etag disabled. |
wesleytodd
left a comment
wesleytodd
left a comment
There was a problem hiding this comment.
Sorry I think this got lost in the backlog of issues. @UlisesGascon do you still think we need more test coverage with this in there?
If not, can we merge this?
This patch introduces the ability to control the ETag generation through the `res.sendFile` function. Specifically, the ETag option is wired to the application's configuration, allowing it to be enabled or disabled based on the app's settings. Fixes: expressjs#2294 Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
wesleytodd
force-pushed
the
juan/etag-plug
branch
from
f7b47d0 to
85cc7f5
Compare
3 participants
This patch introduces the ability to control the ETag generation through the
res.sendFilefunction. Specifically, the ETag option is wired to the application's configuration, allowing it to be enabled or disabled based on the app's settings.Fixes: #2294