CVPN-2519: Expresslane and InsidePktCodec mutually exclusive#412
Open
kp-weiwen-goh wants to merge 4 commits intomainfrom
Open
CVPN-2519: Expresslane and InsidePktCodec mutually exclusive#412kp-weiwen-goh wants to merge 4 commits intomainfrom
kp-weiwen-goh wants to merge 4 commits intomainfrom
Conversation
|
Code coverage summary for e5dfc3b: ✅ Region coverage 69% passes |
216da62 to
e06fd74
Compare
e06fd74 to
e26ecea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
DataPathModeenum that enforces that ExpressLane and InsidePktCodec are never both enabled.ExpressLane cannot be enabled if
DataPathModeisInsidePktCodec.If ExpressLane is enabled when an encoding request is sent or received, ExpressLane is set to
Inactiveand is only re-enabled when encoding is then disabled.Motivation and Context
They are mutually exclusive. Previously, this was not enforced by code and relies on correct user configuration.
How Has This Been Tested?
Types of changes
Checklist:
main