fix: PHP 8.1+ null parameter deprecation in Generator.php#473
Closed
sysmonf wants to merge 1 commit intoezyang:masterfrom
Closed
fix: PHP 8.1+ null parameter deprecation in Generator.php#473sysmonf wants to merge 1 commit intoezyang:masterfrom
sysmonf wants to merge 1 commit intoezyang:masterfrom
Conversation
PHP 8.1+ deprecated passing null to internal string functions. This causes deprecation warnings when attribute values are null in `generateAttributes()` and `escape()` methods. Adds null coalescing operator (`?? ''`) to: - `strpos()` - line 251 - `strcspn()` - line 254 - `strlen()` - line 254 - `htmlspecialchars()` - line 282
Author
|
closing, as I have more extensive patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.1+ deprecated passing null to internal string functions. This causes deprecation warnings when attribute values are null in
generateAttributes()andescape()methods.Adds null coalescing operator (
?? '') to:strpos()- line 251strcspn()- line 254strlen()- line 254htmlspecialchars()- line 282