Draft
Conversation
meta-cla
bot
added
the
CLA Signed
avdv
force-pushed
the
cb/remote-api-retries
branch
from
02c004b to
6fc288e
Compare
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D92160522. (Because this pull request was imported automatically, there will not be any future comments.) |
By default, each RPC has a timeout of 60 seconds applied to it.
Retry 5 times on network / RE retryable errors. This is the same value Bazel uses.
avdv
force-pushed
the
cb/remote-api-retries
branch
from
6fc288e to
4ac5aa8
Compare
avdv
force-pushed
the
cb/remote-api-retries
branch
from
0d9890c to
47e30e5
Compare
josephsumabat
added a commit
to MercuryTechnologies/buck2
that referenced
this pull request
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1136
Note: based upon #1076
Status: WIP
This change adds retry logic, similar to Bazel, for transient errors. By default, every request is retried at most 5 times, with exponential back-off.
Also, it configures a default timeout of 60 secs for each gRPC request, also notifying the server about it. When testing, this had a really nice effect: a build taking up to 3 hours sometimes (due to waiting on some remote response) now finishes in 10 to 20 mins.
(depends on: #1262)