fix: replace https to server to support Webpack 5

[luffy84217]

Describe the bug

Project CRA 5, with a .env.development.local file configured with HTTPS settings, gives deprecation warning.

Actual behavior

A deprecation warning is issued on bootstrap, app still works properly.
Screenshot:

Core idea

create-react-app/packages/react-scripts/config/webpackDevServer.config.js

Line 102 in 20edab4

https: getHttpsConfig(),

Replace https: getHttpsConfig(): { cert: Buffer; key: Buffer; } | boolean
with server: getServerConfig(): "http" | "https" | { type: "https"; options: { cert: Buffer; key: Buffer; }; }

function getServerConfig() {
  const { SSL_CRT_FILE, SSL_KEY_FILE, HTTPS } = process.env;
  const protocol = HTTPS === 'true' ? 'https' : 'http';

  if (protocol === 'https') {
    if (SSL_CRT_FILE && SSL_KEY_FILE) {
      const crtFile = path.resolve(paths.appPath, SSL_CRT_FILE);
      const keyFile = path.resolve(paths.appPath, SSL_KEY_FILE);
      const config = {
        type: protocol,
        options: {
          cert: readEnvFile(crtFile, 'SSL_CRT_FILE'),
          key: readEnvFile(keyFile, 'SSL_KEY_FILE'),
        },
      };

      validateKeyAndCerts({ ...config.options, keyFile, crtFile });
      return config;
    }
    return protocol;
  }
  return protocol;
}

Modify the function to move https config into "server" options and align schemas

After fixing

The deprecation warning is eliminated successfully.
Screenshot:

[luffy84217]

@iansu @mrmckeb Would you please take a look at this?

[carlosparreno]

@iansu @mrmckeb Would you please take a look at this?

Hello, any update on this, please? Thanks a lot in advance.

[vHeemstra]

Still there: [DEP_WEBPACK_DEV_SERVER_HTTPS] DeprecationWarning: 'https' option is deprecated. Please use the 'server' option. warning when using the HTTPS option.
Seems like an easy merge of this PR.. :)

[luffy84217]

@vHeemstra Yes, but no one takes a look at this and approves the PR :(

[ivorscott]

LGTM. Can we merge this?

[blendPOS]

Has there been any progress?

[artyom-88]

Hi @iansu @mrmckeb, could you review the PR please?

[rileyjshaw]

Thanks for fixing this, I hope it gets merged soon!

[larsschenk]

Another year+ and still open and not merged or am I missing something?