[Nexthop][fboss2-dev] Add fboss2-dev config mac aging-time CLI command#1178
[Nexthop][fboss2-dev] Add fboss2-dev config mac aging-time CLI command#1178vybhav-nexthop wants to merge 1 commit into
Conversation
|
Hi @vybhav-nexthop! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Implements `fboss2-dev config mac aging-time <seconds>` to set the L2 MAC address aging timer (l2AgeTimerSeconds in SwitchSettings). The change is HITLESS (no agent restart required).
2c20dcc to
bff5c1c
Compare
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Adds
fboss2-dev config mac aging-time <seconds>to set the L2 MACaddress aging timer (
l2AgeTimerSecondsinSwitchSettings, default300s).
The change is applied HITLESSLY by the SAI layer
(
SaiSwitch.cpp::setMacAgingSeconds(), noChangeProhibitedguard).New files:
commands/config/mac/CmdConfigMac.{h,cpp}— parent branch nodecommands/config/mac/aging_time/CmdConfigMacAgingTime.{h,cpp}— leaf handler with positive-integer validationtest/config/CmdConfigMacAgingTimeTest.cpp— unit tests (arg validation, set, already-set)test/integration_test/ConfigMacTest.cpp— E2E set/restore testModified:
CmdListConfig.cpp,cmake/CliFboss2.cmake,cmake/CliFboss2TestConfig.cmake,cmake/CliFboss2TestIntegrationTest.cmake,fboss2/BUCK,test/config/BUCK,test/integration_test/BUCKTest Plan
Unit tests — 3 test cases covering arg validation, set, and already-set no-op:
Integration test —
ConfigMacTest.SetAndRestoreAgingTimeon a DUT (set aging-time, verify, restore).