decouple compileSdk version from build tools version#21205
Closed
dulmandakh wants to merge 2 commits intofacebook:masterfrom
Closed
decouple compileSdk version from build tools version#21205dulmandakh wants to merge 2 commits intofacebook:masterfrom
dulmandakh wants to merge 2 commits intofacebook:masterfrom
Conversation
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
✅Test Plan
Missing Changelog
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 19, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
@dulmandakh merged commit bc8d052 into Once this commit is added to a release, you will see the corresponding version tag below the description at bc8d052. If the commit has a single |
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Android CI was failing due to that it was trying to extract major version from build tools and use it to compile ReactAndroid. Now, it'll extract compileSdkVersion from ReactAndroid/build.gradle and use it. Issue was that facebook@68c7999 dowgraded compileSdk version to 26 while retaining build tools version as 27.0.3, so CI was trying to use SDK 27. Pull Request resolved: facebook#21205 Differential Revision: D9943909 Pulled By: hramos fbshipit-source-id: ec9bc0c40956a16f8088532340722fd43cadde37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android CI was failing due to that it was trying to extract major version from build tools and use it to compile ReactAndroid. Now, it'll extract compileSdkVersion from ReactAndroid/build.gradle and use it.
Issue was that 68c7999 dowgraded compileSdk version to 26 while retaining build tools version as 27.0.3, so CI was trying to use SDK 27.
Test Plan:
Fixed causes of https://circleci.com/gh/facebook/react-native/52560, https://circleci.com/gh/facebook/react-native/52645. But still failing due to unexported buck dependencies from FB