Skip to content

[flow-strict] Flow strict-local in TimePickerAndroid.android.js #22154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
binaryta wants to merge 3 commits into from
Closed

[flow-strict] Flow strict-local in TimePickerAndroid.android.js #22154

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f26b9ee
Flow strict-local in TimePickerAndroid.android.js
binaryta Nov 5, 2018
ac37a44
Replace getter function into static property
binaryta Nov 5, 2018
ee83ffb
modified to isolate file
binaryta Nov 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions Libraries/Components/TimePickerAndroid/TimePickerAndroid.android.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,15 +76,11 @@ class TimePickerAndroid {
/**
* A time has been selected.
*/
static getTimeSetAction(): string {
return 'timeSetAction';
}
static timeSetAction = 'timeSetAction';
Copy link
Copy Markdown
Contributor

@RSNara RSNara Nov 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. You forgot to make this covariant:

static +timeSetAction: string = 'timeSetAction';

/**
* The dialog has been dismissed.
*/
static getDismissedAction(): string {
return 'dismissedAction';
}
static dismissedAction = 'dismissedAction';
Copy link
Copy Markdown
Contributor

@RSNara RSNara Nov 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to make this covariant:

static +dismissedAction: string = 'dismissedAction';

You need the + after the static and before dismissedAction.

}

module.exports = TimePickerAndroid;
4 changes: 2 additions & 2 deletions RNTester/js/TimePickerAndroidExample.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,11 @@ class TimePickerAndroidExample extends React.Component {
try {
const {action, minute, hour} = await TimePickerAndroid.open(options);
const newState = {};
if (action === TimePickerAndroid.getTimeSetAction) {
if (action === TimePickerAndroid.timeSetAction) {
newState[stateKey + 'Text'] = _formatTime(hour, minute);
newState[stateKey + 'Hour'] = hour;
newState[stateKey + 'Minute'] = minute;
} else if (action === TimePickerAndroid.getDismissedAction) {
} else if (action === TimePickerAndroid.dismissedAction) {
newState[stateKey + 'Text'] = 'dismissed';
}
this.setState(newState);
Expand Down
4 changes: 2 additions & 2 deletions ReactAndroid/src/androidTest/js/TimePickerDialogTestModule.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ var TimePickerDialogTestModule = {
showTimePickerDialog: function(options) {
TimePickerAndroid.open(options).then(
({action, hour, minute}) => {
if (action === TimePickerAndroid.getTimeSetAction) {
if (action === TimePickerAndroid.timeSetAction) {
RecordingModule.recordTime(hour, minute);
} else if (action === TimePickerAndroid.getDismissedAction) {
} else if (action === TimePickerAndroid.dismissedAction) {
RecordingModule.recordDismissed();
}
},
Expand Down