Rename renderToStream to renderToNodeStream.#10425
Merged
aickin merged 2 commits intofacebook:masterfrom Aug 10, 2017
Merged
Conversation
sebmarkbage
approved these changes
Aug 9, 2017
Closed
This was referenced Sep 28, 2017
This was referenced Oct 28, 2017
This was referenced Dec 1, 2017
This was referenced Feb 2, 2018
This was referenced Mar 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a fix for #10388. It renames
renderToStreamtorenderToNodeStreamandrenderToStaticStreamtorenderToStaticNodeStream.It's basically just a find-and-replace job. Note that the fiber test results changed a lot, but I'm pretty sure after running them that they weren't up-to-date in master, so I'm not worrying about that.
Also, we should also merge the documentation pages
reference-react-dom-server.mdandreference-react-dom-node-stream.mdbefore release, but I left that out of this PR as it is independent of this change.