Support string values for capture attribute.

[maxschmeling]

• Uses HAS_OVERLOADED_BOOLEAN_VALUE instead of HAS_BOOLEAN_VALUE
• Allows for <input type="file" capture="user" />

Fixes #11419

[nhunzaker]

Thanks for sending this out!

[nhunzaker]

Did a couple of tests locally:

it('...', () => {
  var stub = ReactTestUtils.renderIntoDocument(<input capture={false} />);
  var node = ReactDOM.findDOMNode(stub);

  expect(node.getAttribute('capture')).toBe(null)
});

it('...', () => {
  var stub = ReactTestUtils.renderIntoDocument(<input capture={true} />);
  var node = ReactDOM.findDOMNode(stub);

  expect(node.getAttribute('capture')).toBe('')
});

it('...', () => {
  var stub = ReactTestUtils.renderIntoDocument(<input capture="user" />);
  var node = ReactDOM.findDOMNode(stub);

  expect(node.getAttribute('capture')).toBe('user')
});

it('...', () => {
  var stub = ReactTestUtils.renderIntoDocument(<input capture />);
  var node = ReactDOM.findDOMNode(stub);

  expect(node.getAttribute('capture')).toBe('')
});

I think this is pretty safe for a minor.

[gaearon]

I think this is pretty safe for a minor.

Ended up in a patch 😛

We cut releases from master now, so if something should only be merged for a minor, it is best to raise an issue and coordinate. Otherwise we lose the ability to cut quick patch fixes.

But I'm okay treating this one as a patch tbh.

[nhunzaker]

Hehe. No problem. Sounds good! A patch sounds fine to me too.