Remove errant return assignment#14164
Merged
acdlite merged 1 commit intofacebook:masterfrom Nov 9, 2018
Merged
Conversation
acdlite
force-pushed
the
remove-errant-return-assignment
branch
from
f519354 to
da0641c
Compare
Oopsie! This could have been avoided if our types were modeled correctly with Flow (using a disjoint union). Fuzz tester didn't catch it because it does not generate cases where a Suspense component mounts with no children. I'll update it.
acdlite
force-pushed
the
remove-errant-return-assignment
branch
from
da0641c to
355c0be
Compare
Details of bundled changes.Comparing: 7fd1661...355c0be scheduler
Generated by 🚫 dangerJS |
sophiebits
reviewed
Nov 9, 2018
Collaborator
sophiebits
left a comment
sophiebits
left a comment
There was a problem hiding this comment.
Do you not need to update the return pointer on currentPrimaryChild and its siblings (when they exist)?
Collaborator
Author
|
@sophiebits You do right before you traverse down into them, which is not true in this case. I think this is some copypasta from a different branch. |
sebmarkbage
approved these changes
Nov 9, 2018
This was referenced Nov 12, 2018
Merged
This was referenced Dec 1, 2018
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
Oopsie! This could have been avoided if our types were modeled correctly with Flow (using a disjoint union). Fuzz tester didn't catch it because it does not generate cases where a Suspense component mounts with no children. I'll update it.
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
Oopsie! This could have been avoided if our types were modeled correctly with Flow (using a disjoint union). Fuzz tester didn't catch it because it does not generate cases where a Suspense component mounts with no children. I'll update it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oopsie!
This could have been avoided if our types were modeled correctly with Flow (using a disjoint union).
Fuzz tester didn't catch it because it does not generate cases where a Suspense component mounts with no children. I'll update it.
Fixes #14162