Skip to content

[Flare] EventPriority enum#15823

Merged
acdlite merged 2 commits into
facebook:masterfrom
acdlite:user-blocking-events-flare
Jun 5, 2019
Merged

[Flare] EventPriority enum#15823
acdlite merged 2 commits into
facebook:masterfrom
acdlite:user-blocking-events-flare

Conversation

@acdlite
Copy link
Copy Markdown
Collaborator

@acdlite acdlite commented Jun 4, 2019

Same as #15811 but for Flare.

I don't know what the public API for setting the event priority should be. Right now it accepts a numeric enum, but is this what we want? Maybe it should be a string enum? I've punted on this until I receive feedback.

@acdlite
Same as previous commit, but for Flare
180cc5d 
I don't know what the public API for setting the event priority should
be. Right now it accepts a numeric enum, but is this what we want?
Maybe it should be a string enum? I've punted on this for now.
@acdlite acdlite requested a review from trueadm June 4, 2019 20:39
@sizebot
Copy link
Copy Markdown

sizebot commented Jun 4, 2019 •
edited
Loading

ReactDOM: size: 0.0%, gzip: 🔺+0.1%

Details of bundled changes.

Comparing: 6b5deee...cbb943f

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% 0.0% 109.24 KB 109.24 KB 34.7 KB 34.7 KB NODE_PROFILING
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.76 KB 60.76 KB 15.84 KB 15.85 KB UMD_DEV
ReactDOM-dev.js +0.1% +0.1% 883.48 KB 884.13 KB 196.81 KB 196.96 KB FB_WWW_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.69 KB 10.69 KB 3.66 KB 3.67 KB UMD_PROD
ReactDOMServer-dev.js 0.0% 0.0% 135.5 KB 135.5 KB 34.81 KB 34.81 KB FB_WWW_DEV
react-dom-unstable-fire.development.js +0.1% +0.1% 863.96 KB 864.61 KB 197.01 KB 197.15 KB UMD_DEV
react-dom-unstable-fire.production.min.js 0.0% 0.0% 105.92 KB 105.92 KB 34.45 KB 34.45 KB UMD_PROD
react-dom-unstable-fire.profiling.min.js 0.0% 0.0% 109.07 KB 109.07 KB 35.4 KB 35.41 KB UMD_PROFILING
react-dom-unstable-fire.development.js +0.1% +0.1% 858.3 KB 858.96 KB 195.42 KB 195.58 KB NODE_DEV
react-dom-server.node.development.js 0.0% 0.0% 135.35 KB 135.35 KB 35.84 KB 35.85 KB NODE_DEV
react-dom-unstable-fire.production.min.js 0.0% 0.0% 105.92 KB 105.92 KB 33.86 KB 33.86 KB NODE_PROD
react-dom.development.js +0.1% +0.1% 863.61 KB 864.26 KB 196.87 KB 197 KB UMD_DEV
react-dom-unstable-fire.profiling.min.js 0.0% 0.0% 109.25 KB 109.25 KB 34.71 KB 34.71 KB NODE_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 137.28 KB 137.28 KB 36.23 KB 36.24 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 105.91 KB 105.91 KB 34.44 KB 34.44 KB UMD_PROD
ReactFire-dev.js +0.1% +0.1% 882.69 KB 883.34 KB 196.75 KB 196.89 KB FB_WWW_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 19.2 KB 19.2 KB 7.22 KB 7.23 KB UMD_PROD
react-dom.profiling.min.js 0.0% 0.0% 109.06 KB 109.06 KB 35.4 KB 35.4 KB UMD_PROFILING
ReactFire-prod.js 🔺+0.1% 🔺+0.1% 345.71 KB 346.17 KB 63.61 KB 63.66 KB FB_WWW_PROD
react-dom.development.js +0.1% +0.1% 857.95 KB 858.62 KB 195.28 KB 195.44 KB NODE_DEV
ReactFire-profiling.js +0.1% +0.1% 350.98 KB 351.44 KB 64.5 KB 64.54 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 133.41 KB 133.41 KB 35.3 KB 35.3 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 105.9 KB 105.9 KB 33.85 KB 33.85 KB NODE_PROD
react-dom-server.browser.production.min.js 0.0% 0.0% 19.12 KB 19.12 KB 7.22 KB 7.22 KB NODE_PROD
ReactDOM-prod.js 🔺+0.1% 🔺+0.1% 357.73 KB 358.19 KB 66.09 KB 66.14 KB FB_WWW_PROD
ReactDOMServer-prod.js 0.0% 0.0% 47.93 KB 47.93 KB 11.03 KB 11.03 KB FB_WWW_PROD
ReactDOM-profiling.js +0.1% +0.1% 362.97 KB 363.43 KB 66.97 KB 67.03 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 60.43 KB 60.43 KB 15.72 KB 15.72 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 3.88 KB 3.88 KB 1.51 KB 1.51 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 🔺+0.1% 10.43 KB 10.43 KB 3.56 KB 3.57 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.3% 1.1 KB 1.1 KB 665 B 667 B NODE_PROD
react-dom-test-utils.development.js 0.0% 0.0% 57.64 KB 57.64 KB 15.85 KB 15.85 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.81 KB 3.81 KB 1.53 KB 1.54 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 10.81 KB 10.81 KB 3.97 KB 3.97 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.3% 1.21 KB 1.21 KB 704 B 706 B UMD_PROD
react-dom-test-utils.development.js 0.0% 0.0% 55.98 KB 55.98 KB 15.53 KB 15.53 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.2% 3.64 KB 3.64 KB 1.49 KB 1.49 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 🔺+0.1% 10.56 KB 10.56 KB 3.91 KB 3.92 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.3% 1.05 KB 1.05 KB 635 B 637 B NODE_PROD

Generated by 🚫 dangerJS

@acdlite
Copy link
Copy Markdown
Collaborator Author

acdlite commented Jun 4, 2019

Another option is to keep the isDiscrete option to dispatchEvent as-is, and call Scheduler.runWithPriority directly.

trueadm
trueadm approved these changes Jun 4, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really happy with this and it makes sense given our earlier discussion. @necolas what do you think?

@necolas
Copy link
Copy Markdown
Contributor

necolas commented Jun 4, 2019

lgtm

@acdlite acdlite merged commit 7b28ad1 into facebook:master Jun 5, 2019
rickhanlonii pushed a commit to rickhanlonii/react that referenced this pull request Jun 25, 2019
@acdlite @rickhanlonii
[Flare] EventPriority enum (facebook#15823)
9307048 
* Same as previous commit, but for Flare

I don't know what the public API for setting the event priority should
be. Right now it accepts a numeric enum, but is this what we want?
Maybe it should be a string enum? I've punted on this for now.

* Add test for hover events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@trueadm trueadm trueadm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@acdlite @sizebot @necolas @trueadm @facebook-github-bot