[Flare] Improve runtime performance of hit target intersection#15836
Merged
Conversation
Details of bundled changes.Comparing: def56c9...1e4afbc react-events
Generated by 🚫 dangerJS |
necolas
approved these changes
Jun 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During internal testing, we found the
document.getElementFromPointto be quite expensive. We can avoid using this DOM API entirely if we instead pass around theResponderEventobject and calculate the same properties from thenativeEventco-ords using the current event target. This also has a nice side-effect of reducing code-size slightly too.