Revert "Add support to exhaustive-deps rule for any hook ending with Effect"#19004
Merged
gaearon merged 1 commit intofacebook:masterfrom May 26, 2020
Merged
Revert "Add support to exhaustive-deps rule for any hook ending with Effect"#19004gaearon merged 1 commit intofacebook:masterfrom
exhaustive-deps rule for any hook ending with Effect"#19004gaearon merged 1 commit intofacebook:masterfrom
Conversation
…nding with `Effect` (facebook#18580)" This reverts commit 5ac9ca7.
facebook-github-bot
added
CLA Signed
React Core Team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ba33105:
|
trueadm
approved these changes
May 26, 2020
bvaughn
approved these changes
May 26, 2020
Contributor
|
I'd like to propose #18861 as an alternative solution for this |
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #18580.
I thought we might try this but there's both bugs in the implementation (#19001) and too many false positives (#18580 (comment), #18580 (comment), #18858, #18888). I think it's clear this heuristic hasn't worked out.