fix(eslint-plugin-react-hooks): Support nullish coalescing and optional chaining of dependencies#19008
Merged
gaearon merged 1 commit intofacebook:masterfrom May 27, 2020
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6faded2:
|
… and optional chaining of dependencies, relates to facebook#18985
93ccd5a to
6faded2
Compare
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #18985
Summary
In conditions where optional chaining is used inside the
useEffecthook, thereact-hooks/exhaustive-depsrule falsely flags missing dependencies. This change adds some logic to the linting rules to also match dependencies with optional chaining.Test Plan
Have added tests to cover the following valid scenarios that were previously failing: