Update isUnknownEvent to UpdateType enum#25371
Closed
tyao1 wants to merge 6 commits intofacebook:mainfrom
Closed
Conversation
tyao1
force-pushed
the
synchronous-enum
branch
from
e469446 to
d6e6750
Compare
tyao1
force-pushed
the
synchronous-enum
branch
from
0b63508 to
3f9e2cc
Compare
Contributor
Author
|
redoing it in #25460 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Based on commits in #25310.
isUnknownEventwas specific for frame aligned update, and we want to unify more types of synchronous update. This PR makes this an enum to support that.How did you test this change?
yarn lint