Merged
Conversation
[ghstack-poisoned]
This was referenced Oct 4, 2022
Merged
Merged
Closed
facebook-github-bot
added
CLA Signed
React Core Team
kassens
added a commit
to kassens/react
that referenced
this pull request
Oct 4, 2022
ghstack-source-id: 58e651c Pull Request resolved: facebook#25419
gaearon
reviewed
Oct 4, 2022
| type Check<_X, Y: _X, X: Y = _X> = null; | ||
| // eslint-disable-next-line no-unused-expressions | ||
| (null: Check<ExportsType, FeatureFlagsType>); | ||
| // Flow magic to verify the exports of this file match the original version. |
Collaborator
There was a problem hiding this comment.
Have you verified this still does what it's supposed to?
Member
Author
There was a problem hiding this comment.
I changed one export type and it showed an error.
The idea is that A can be casted into B and B can be casted into A, which I think implies that A = B.
gaearon
approved these changes
Oct 4, 2022
[ghstack-poisoned]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):