Add regression test to attribute-behavior fixture#28349
Open
eps1lon wants to merge 4 commits intofacebook:mainfrom
Open
Add regression test to attribute-behavior fixture#28349eps1lon wants to merge 4 commits intofacebook:mainfrom
eps1lon wants to merge 4 commits intofacebook:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
React Core Team
eps1lon
commented
Feb 15, 2024
| "@playwright/test": "^1.41.2" | ||
| }, | ||
| "optionalDependencies": { | ||
| "fsevents": "1.2.13" |
Collaborator
Author
There was a problem hiding this comment.
Required to work around yarnpkg/yarn#7273 on Linux.
Also requires running install with --ignore-optional
|
Comparing: bf09089...2c3e242 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
eps1lon
force-pushed
the
test/fixture-attribute-behavior
branch
5 times, most recently
from
e53d7c8 to
7ae6e02
Compare
eps1lon
force-pushed
the
test/fixture-attribute-behavior
branch
from
7ae6e02 to
fa93c58
Compare
eps1lon
force-pushed
the
test/fixture-attribute-behavior
branch
from
958bbd7 to
2c3e242
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixture changed multiple times in the past without us noticing. This adds an automated test using Playwright that ensures the snapshot is unchanged. The new snapshot is saved as an artifact to make it easier to save if changes are intentional.
The test itself currently takes ~35s. The whole job takes ~2min13s and does not increase wall time of the full pipeline.
The main motivation are smoke tests for other fixtures (e.g. #28350). I only started with attribute-behavior because I know it's up-to-date and I'm familiar with it.
How did you test this change?